Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMU test - Fix forward kinematics computation #76

Merged
merged 2 commits into from
May 10, 2024

Conversation

martinaxgloria
Copy link
Contributor

During the demo shown at the last PI review, we found an error when asking for the test to be performed on all sensors, while passing a specific list of sensors (i.e. l_arm_ft_imu, r_arm_ft_imu, head_imu_0) resulted in a positive test result for the imu sensor on the head. Trying to combine the elements of this list in different ways, the only green light was obtained when the head_imu_0 was the third element of the list.

Thanks to the precious help of @Nicogene, we found out that it was a leftover in the computation of the forward kinematics. When the test was executed sequentially over the available sensors, the rotation matrix I_R_I_IMU was computed and then overwritten. When the test was refactored to be executed on all the available sensors at the same time, I didn't transform this iDynTree::Rotation in a std::vector<iDynTree::Rotation> (one per sensor).

This PR adds this fix (tested on iCubGenova11 with @Nicogene). Moreover, I also added a new configuration file to be used with robots that are not equipped with legs

@Nicogene
Copy link
Member

cc @pattacini

@Nicogene Nicogene merged commit 37642b9 into robotology:devel May 10, 2024
3 checks passed
@martinaxgloria martinaxgloria deleted the patch-1 branch May 10, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants